[cli] permission cleanup on 'superset init' #4241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FAB sometimes creates NULL/None permissions in the database, presumably a race condition when multiple gunicorn workers start at the same time, and those create issues raising "AttributeError: 'NoneType' object has no attribute 'name'"
|
🚢 |
|
@mistercrunch FAB also hase this method for security cleanup (https://github.com/dpgaspar/Flask-AppBuilder/blob/master/flask_appbuilder/security/manager.py#L845). I'm not sure whether it would resolve the same issue. It's documented here. |
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* [cli] permission cleanup on 'superset init' FAB sometimes creates NULL/None permissions in the database, presumably a race condition when multiple gunicorn workers start at the same time, and those create issues raising "AttributeError: 'NoneType' object has no attribute 'name'" * Linting
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* [cli] permission cleanup on 'superset init' FAB sometimes creates NULL/None permissions in the database, presumably a race condition when multiple gunicorn workers start at the same time, and those create issues raising "AttributeError: 'NoneType' object has no attribute 'name'" * Linting
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FAB sometimes creates NULL/None permissions in the database,
presumably a race condition when multiple gunicorn workers start at the
same time, and those create issues raising "AttributeError: 'NoneType'
object has no attribute 'name'"